Conversation
🦋 Changeset detectedLatest commit: e1ed7b5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
approved these changes
Sep 6, 2023
bluwy
approved these changes
Sep 6, 2023
Member
bluwy
left a comment
There was a problem hiding this comment.
LGTM. Seems like it's able to serve both with and without a basepath. The error was happening because we inject a script that's processed by Vite. Injecting as an inline script could also solve this.
Contributor
Author
|
Astro's 'head-inline' scripts are non-module scripts so that wouldn't work here. Going with this as it seems to work. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@react-refresh. Previously we were loading it as/basepathname/@react-refresh. Instead packages need to be loaded from the absolute root, regardless of whether a base is used or not.Testing
Docs
N/A, bug fix