addpkg(x11/liquidshell): 1.10.1#29438
Draft
BullyMaguire-lol wants to merge 1 commit intotermux:masterfrom
Draft
Conversation
BullyMaguire-lol
changed the title
| + } | ||
| +} | ||
| + | ||
| +if (!bestMatch.isEmpty()) |
Member
There was a problem hiding this comment.
Why is this necessary? What wallpaper path does this end up with when it runs?
TomJo2000
reviewed
Apr 20, 2026
Comment on lines
+21
to
+26
| + bool ok1 = false, ok2 = false; | ||
| + int w = parts[0].toInt(&ok1); | ||
| + int h = parts[1].split('.')[0].toInt(&ok2); | ||
| + | ||
| + if (!ok1 || !ok2) | ||
| + continue; |
Member
There was a problem hiding this comment.
Doesn't this always continue?
! false is true, and I don't see either ok1 or ok2 getting reassigned.
Also isn't &var the memory location of a variable?
I guess I don't know what property the .toInt() method on a QStringList returns.
But I wouldn't expect it to take in memory location.
Presumably this works, but it looks odd to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Liquidshell is an alternative to plasmashell. It does not use QtQuick but instead relies on QtWidgets, therefore no hardware graphics acceleration is needed.