Not all versions of a package are updated if the package is listed multiple times

[fidian]

• I have searched for similar issues

---

Steps to Reproduce

.ncurc:

No .ncurc file is used.

Dependencies:

{
    "dependencies": {
        "fudgel": "2.6.0"
    },
    "peerDependencies": {
        "fudgel": "2.6.1"
    }
}

Steps:

1. Start with two different versions of the same package.
2. Run npm-check-updates -u --dep dev,optional,peer,prod,packageManager

Current Behavior

Only one of the packages is updated to the latest instead of both.

Expected Behavior

Both packages are updated

Sample Output

$ cat package.json
{
    "dependencies": {
        "fudgel": "2.6.0"
    },
    "peerDependencies": {
        "fudgel": "2.6.1"
    }
}

$ npm-check-updates -u --dep dev,optional,peer,prod,packageManager
Upgrading /[removed]/package.json
[====================] 1/1 100%

 fudgel  2.6.0  →  3.1.0

Run npm install to install new versions.

$ cat package.json
{
    "dependencies": {
        "fudgel": "3.1.0"
    },
    "peerDependencies": {
        "fudgel": "2.6.1"
    }
}

$ npm-check-updates -u --dep dev,optional,peer,prod,packageManager
Upgrading /[removed]/package.json
[====================] 1/1 100%

 fudgel  2.6.1  →  3.1.0

Run npm install to install new versions.

$ cat package.json
{
    "dependencies": {
        "fudgel": "3.1.0"
    },
    "peerDependencies": {
        "fudgel": "3.1.0"
    }
}

[raineorshine]

Hi, thanks for reporting. I can confirm that this is a bug.

Unfortunately npm-check-updates is not very well equipped to differentiate upgrades of duplicate dependencies in different sections. Throughout the codebase the current dependencies are passed as a { [name]: version } object, so the dep section information is lost. It currently only upgrades the lowest version.

npm-check-updates/src/lib/getCurrentDependencies.ts

Lines 39 to 41 in 168325c

	// get all dependencies from the selected sections
	// if a dependency appears in more than one section, take the lowest version number
	const allDependencies = depSections.reduce((accum, depSection) => {

So this is a nontrivial change and probably not a high priority given the less common usage. For peerDependencies in particular it is recommended to use the lowest compatible dependency, which is why that section is not upgraded by default. In an ideal world though the expected behavior should be exactly as you described.