Skip to content

feat(web): add archive action to thread context menu#2213

Open
maria-rcks wants to merge 1 commit intopingdotgg:mainfrom
maria-rcks:feat/archive-thread-context-menu
Open

feat(web): add archive action to thread context menu#2213
maria-rcks wants to merge 1 commit intopingdotgg:mainfrom
maria-rcks:feat/archive-thread-context-menu

Conversation

@maria-rcks
Copy link
Copy Markdown
Collaborator

@maria-rcks maria-rcks commented Apr 20, 2026

What Changed

Added "Archive" option in context menu of threads in the sidebar.

Why

because (I believe) its better ux to have it there too, not only as an icon you have to click in the sidebar.

UI Changes

before after
image image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk UI change that adds a new sidebar context-menu action and a regression test; behavior is gated/disabled while a thread is actively running.

Overview
Adds an Archive action to the sidebar thread right-click context menu, wiring it to the existing attemptArchiveThread flow and disabling it when the thread has an active running turn.

Extends the browser test suite (ChatView.browser.tsx) with coverage that the context menu includes archive and that selecting it triggers the thread.archive dispatch over the websocket harness.

Reviewed by Cursor Bugbot for commit af4be23. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add archive action to thread context menu in sidebar

  • Adds an 'Archive' item to the right-click context menu for threads in Sidebar.tsx, invoking attemptArchiveThread when selected.
  • The archive option is disabled when the thread is currently running (status is running or an active turn is present).
  • Adds a browser test in ChatView.browser.tsx verifying the context menu contains the archive item and dispatches a thread.archive command on selection.

Macroscope summarized af4be23.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 20, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bd7da617-f686-4ff5-93ea-11792e93a45d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 20, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit af4be23. Configure here.

if (clicked === "archive") {
await attemptArchiveThread(threadRef);
return;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Archive context menu skips user's confirmation preference

Medium Severity

The new "archive" handler in the context menu calls attemptArchiveThread directly, bypassing the user's appSettingsConfirmThreadArchive setting. The "delete" handler at line 1921 correctly checks appSettingsConfirmThreadDelete and shows a confirmation dialog via api.dialogs.confirm before proceeding. The archive handler needs the same pattern — checking appSettingsConfirmThreadArchive and prompting before archiving — to stay consistent with the sidebar's two-step archive confirmation flow.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit af4be23. Configure here.

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 20, 2026

Approvability

Verdict: Needs human review

An unresolved review comment identifies that the new archive handler bypasses the user's confirmation preference setting, unlike the existing delete handler. This inconsistency with user preferences is a substantive issue that should be addressed before merging.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant