feat(web): add archive action to thread context menu#2213
feat(web): add archive action to thread context menu#2213maria-rcks wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit af4be23. Configure here.
| if (clicked === "archive") { | ||
| await attemptArchiveThread(threadRef); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Archive context menu skips user's confirmation preference
Medium Severity
The new "archive" handler in the context menu calls attemptArchiveThread directly, bypassing the user's appSettingsConfirmThreadArchive setting. The "delete" handler at line 1921 correctly checks appSettingsConfirmThreadDelete and shows a confirmation dialog via api.dialogs.confirm before proceeding. The archive handler needs the same pattern — checking appSettingsConfirmThreadArchive and prompting before archiving — to stay consistent with the sidebar's two-step archive confirmation flow.
Reviewed by Cursor Bugbot for commit af4be23. Configure here.
ApprovabilityVerdict: Needs human review An unresolved review comment identifies that the new archive handler bypasses the user's confirmation preference setting, unlike the existing delete handler. This inconsistency with user preferences is a substantive issue that should be addressed before merging. You can customize Macroscope's approvability policy. Learn more. |


What Changed
Added "Archive" option in context menu of threads in the sidebar.
Why
because (I believe) its better ux to have it there too, not only as an icon you have to click in the sidebar.
UI Changes
Checklist
Note
Low Risk
Low risk UI change that adds a new sidebar context-menu action and a regression test; behavior is gated/disabled while a thread is actively running.
Overview
Adds an Archive action to the sidebar thread right-click context menu, wiring it to the existing
attemptArchiveThreadflow and disabling it when the thread has an active running turn.Extends the browser test suite (
ChatView.browser.tsx) with coverage that the context menu includesarchiveand that selecting it triggers thethread.archivedispatch over the websocket harness.Reviewed by Cursor Bugbot for commit af4be23. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add archive action to thread context menu in sidebar
attemptArchiveThreadwhen selected.runningor an active turn is present).thread.archivecommand on selection.Macroscope summarized af4be23.