fix: correct typo in comment from 'legaxy' to 'legacy'#1792
Open
sbusanelli wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: correct typo in comment from 'legaxy' to 'legacy'#1792sbusanelli wants to merge 1 commit intomicrosoft:mainfrom
sbusanelli wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected a misspelling in line 583 of packages/markitdown/src/markitdown/_markitdown.py where "legaxy" was written instead of "legacy" in a comment about handling legacy keyword arguments.
Changes Made
File: packages/markitdown/src/markitdown/_markitdown.py
Line: 583
Before: # Add legaxy kwargs
After: # Add legacy kwargs
Type of Change
Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Why This Change
While this typo didn't affect functionality, fixing it improves code quality and maintainability by ensuring comments are correctly spelled and professional.
Testing
This change only modifies a comment and requires no additional testing. The functionality remains unchanged.