Skip to content

fix(cli): normalize trigger user ids for sessions#5402

Open
MukundaKatta wants to merge 2 commits intogoogle:mainfrom
MukundaKatta:codex/trigger-user-id-path-safe
Open

fix(cli): normalize trigger user ids for sessions#5402
MukundaKatta wants to merge 2 commits intogoogle:mainfrom
MukundaKatta:codex/trigger-user-id-path-safe

Conversation

@MukundaKatta
Copy link
Copy Markdown

Summary

  • normalize Pub/Sub subscription and Eventarc source metadata before reusing them as session user ids
  • replace slash-separated resource paths with path-safe -- delimiters while preserving the full resource identity
  • add trigger endpoint regression tests that verify the created sessions are stored under the normalized user ids

Testing

  • python3 -m py_compile src/google/adk/cli/trigger_routes.py tests/unittests/cli/test_trigger_routes.py
  • python3 -m pytest tests/unittests/cli/test_trigger_routes.py -k "path_safe or with_subscription_metadata or source_from_ce_header" (fails during collection in this environment: ModuleNotFoundError: No module named 'fastapi')

@adk-bot adk-bot added the tools [Component] This issue is related to tools label Apr 20, 2026
@adk-bot
Copy link
Copy Markdown
Collaborator

adk-bot commented Apr 20, 2026

Response from ADK Triaging Agent

Hello @MukundaKatta, thank you for creating this PR!

This PR is a bug fix, could you please associate the github issue with this PR? If there is no existing issue, could you please create one?

This information will help reviewers to review your PR more efficiently. Thanks!

@rohityan rohityan self-assigned this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools [Component] This issue is related to tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants