fix: preserve anthropic assistant ids in tool-first streams#480
Open
shaked-frame wants to merge 1 commit intoTanStack:mainfrom
Open
fix: preserve anthropic assistant ids in tool-first streams#480shaked-frame wants to merge 1 commit intoTanStack:mainfrom
shaked-frame wants to merge 1 commit intoTanStack:mainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughThe Anthropic text adapter now includes a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parentMessageIdto AnthropicTOOL_CALL_STARTchunks so tool-first streams bind to the eventual assistant message id immediatelyTEXT_MESSAGE_STARTparentMessageIdpreserve a single assistant message instead of creating a temporary local idfixes #477
Verification
pnpm exec vitest run packages/typescript/ai/tests/stream-processor.test.tspnpm test:lib -- --runInBandinpackages/typescript/aistream-processorregression passed@tanstack/ai-event-client,examples/ts-svelte-chat/.svelte-kit/tsconfig.json)pnpm test:lib -- --runInBandinpackages/typescript/ai-anthropic@tanstack/aipackage-entry resolution issue before the adapter test file runsSummary by CodeRabbit
Bug Fixes
Tests