fix: skip unnecessary network reset during emulation restore#1891
Open
dhananjay6561 wants to merge 2 commits intoChromeDevTools:mainfrom
Open
fix: skip unnecessary network reset during emulation restore#1891dhananjay6561 wants to merge 2 commits intoChromeDevTools:mainfrom
dhananjay6561 wants to merge 2 commits intoChromeDevTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@Lightning00Blade hi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #1797
Summary
Fixes a Lighthouse audit failure where
Network.emulateNetworkConditionscould hang during emulation restore.Root cause
lighthouse_auditalways runsrestoreEmulation()in afinallyblock.During restore,
McpContext.emulate()always calledpage.emulateNetworkConditions(null)whennetworkConditionswas not set.On some Chrome/CDP combinations, that reset call can time out even though no network emulation was active.
What changed
skipNetworkResetoption toMcpContext.emulate().restoreEmulation()to skip the network reset when the page had no savednetworkConditions.Validation
npm run test:no-build -- tests/McpContext.test.tsnpm run test:no-build -- tests/tools/lighthouse.test.tsRisk
Low. The change only avoids one unnecessary network-reset call when there was nothing to reset.