Skip to content

CONTRIBUTING.md

Latest commit

 

History

History
164 lines (111 loc) · 4.79 KB

CONTRIBUTING.md

File metadata and controls

164 lines (111 loc) · 4.79 KB

Contributing guidelines

ClickHouse-connect is an open-source project, and we welcome any contributions from the community. Please share your ideas, contribute to the codebase, and help us maintain up-to-date documentation.

Setting up your environment

Prerequisites

Create a fork of the repository and clone it

git clone https://github.com/[YOUR_USERNAME]/clickhouse-connect
cd clickhouse-connect

Add PYTHONPATH

Add the project directory to the PYTHONPATH environment variable to make the driver sources are available for import.

export PYTHONPATH="/absolute/path/to/clickhouse-connect"

Prepare a new virtual environment

You could either use PyCharm for that, or follow the instructions on the official website and set it up via the command line.

Install dependencies

python -m pip install --upgrade pip
pip install setuptools wheel
pip install -r tests/test_requirements.txt
pre-commit install

Run the setup script

The driver uses several Cython extensions that provide additional performance improvements (see the clickhouse_connect/driverc directory). To compile the extensions, run the following command:

python setup.py build_ext --inplace

Additionally, this command is required to provide SQLAlchemy entrypoints:

python setup.py develop

Add /etc/hosts entry

Required for TLS tests. The generated certificates assume TLS requests use server1.clickhouse.test as the hostname. See test_tls.py for more details.

sudo -- sh -c "echo 127.0.0.1 server1.clickhouse.test >> /etc/hosts"

PyCharm setup

If you use PyCharm as your IDE, make sure that you have clickhouse-connect added to the project structure as a source path. Go to Settings -> Project (clickhouse-connect) -> Project structure, right click on clickhouse-connect folder, and mark it as "Sources".

Testing

Start ClickHouse in Docker

The tests will require two ClickHouse instances to be running. One should have a default plain authentication (for integration tests), and the other should have a TLS configuration (for tls tests only).

The integration tests will start and stop the ClickHouse instance automatically. However, this adds a few seconds to each run, and this might not be ideal when you run a single test (using PyCharm, for example). To disable this behavior, set the CLICKHOUSE_CONNECT_TEST_DOCKER environment variable to 0.

export CLICKHOUSE_CONNECT_TEST_DOCKER=0

The easiest way to start all the required ClickHouse instances is to use the provided Docker Compose file (the integrations tests setup script uses the same file).

docker compose up -d

Run the tests

The project uses pytest as a test runner. To run all the tests (unit and integration) execute the following command:

pytest tests

If you need to run the unit tests only:

pytest tests/unit_tests

Or the integration tests only:

pytest tests/integration_tests

Run the TLS integration tests

These tests require the CLICKHOUSE_CONNECT_TEST_TLS environment variable to be set to 1; otherwise, they will be skipped. Additionally, the TLS ClickHouse instance should be running (see docker-compose.yml).

CLICKHOUSE_CONNECT_TEST_TLS=1 pytest tests/integration_tests/test_tls.py

Running the integration tests with ClickHouse Cloud

If you want to run the tests using your ClickHouse Cloud instance instead of the local ClickHouse instance running in Docker, you will need a few additional environment variables.

export CLICKHOUSE_CONNECT_TEST_CLOUD=1
export CLICKHOUSE_CONNECT_TEST_PORT=8443
export CLICKHOUSE_CONNECT_TEST_HOST='instance.clickhouse.cloud'
export CLICKHOUSE_CONNECT_TEST_PASSWORD='secret'

Then, you should be able to run the tests as usual:

pytest tests/integration_tests

Style Guide

The project uses Ruff for linting and formatting. It is always a good idea to run the linter before committing the changes, as this is a mandatory CI check. For example:

pip install ruff
ruff format --check clickhouse_connect tests examples setup.py
ruff check clickhouse_connect tests examples setup.py

To auto-fix issues:

ruff format clickhouse_connect tests examples setup.py
ruff check --fix clickhouse_connect tests examples setup.py

Git blame

Bulk formatting commits are listed in .git-blame-ignore-revs. To configure git blame to skip them:

git config blame.ignoreRevsFile .git-blame-ignore-revs